Skip to content

Wire up NPM for measure evaluation #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

Wire up NPM for measure evaluation #729

wants to merge 31 commits into from

Conversation

@lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Sep 3, 2025 •
edited
Loading

  • Support NPM measure evaluation
  • This includes CareGaps, which uses the measure services
  • R4 only
  • This includes R4RepositoryOrNpmResourceProvider, which will either use the Repository or NPM depending on EvaluationSettings, and will throw Exceptions in most cases for queries not supported by either mechanism
  • Unit tests
  • Spring config changes
  • Some unrelated refactoring to deal with Sonar warnings

@lukedegruchy
Add all utilities classes as well as tests to support NPM. Test tgzs …
d2f0b73 
…and scenarios still need to be tweaked.
@lukedegruchy
All R4 tests working.
533dba6
@lukedegruchy
Start setting up R5.
008137c
@lukedegruchy
More R5 done.
b9a2fa5
@lukedegruchy
All NPM tests working.
49d391a
@lukedegruchy
Delete tgzs that on normal OSs are mixed case instead of the lowercas…
3cfeec3 
…e macOS shows me.
@lukedegruchy
Add back files in lowercase.
4cebd93
@lukedegruchy
Address sonar feedback.
52cc66d
@lukedegruchy
Increase test coverage.
7704709
@lukedegruchy
More test coverage.
fbc36c2
@lukedegruchy
Introduce the concept of an EngineInitializationContext, and use it t…
6fd4a08 
…o capture state with which to initialize CqlEngines within clinical-reasoning. This will initially capture Repository, NpmPackageLoader, and EvaluationSettings, but as we deprecate and then remove functionality that stores qualifying CI resources within Repository, that construct will be dropped from the context.
@lukedegruchy
Add code to actually add NPM functionality to the CqlEngine evaluatio…
4505eb7 
…n, including an NPM library provider and a model info provider.
@lukedegruchy
Add unit test for NpmLibraryProvider.
0e0f405
@lukedegruchy
Merge remote-tracking branch 'origin/master' into ld-20250829-npm-for…
42898e1 
…-qualifying-resources-round-2
@lukedegruchy
Spotless.
0c0e42b
@lukedegruchy
Sonar.
f12eaf2
@lukedegruchy
Add R4RepositoryOrNpmResourceProvider, which is meant to polymorphica…
3f2a29a 
…lly query qualified CI resources depending on whether NPM is activated. Leave NPM hard-coded to off. Wire it into R4MeasureProcessor and every other class that uses it.
@github-actions
Copy link

github-actions bot commented Sep 3, 2025 •
edited
Loading

Formatting check succeeded!

@codecov
Copy link

codecov bot commented Sep 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 69.75506% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.42%. Comparing base (275f301) to head (bb22591).

Files with missing lines Patch % Lines
...sure/r4/npm/R4RepositoryOrNpmResourceProvider.java 62.70% 49 Missing and 20 partials ⚠️
...opencds/cqf/fhir/cr/hapi/config/r4/CrR4Config.java 0.00% 41 Missing ⚠️
...cqf/fhir/utility/npm/NpmPackageLoaderInMemory.java 76.76% 23 Missing and 10 partials ⚠️
...pencds/cqf/fhir/utility/npm/NpmResourceHolder.java 62.65% 26 Missing and 5 partials ⚠️
...cds/cqf/fhir/cr/hapi/config/CrProcessorConfig.java 0.00% 24 Missing ⚠️
...qf/fhir/utility/npm/NpmPackageLoaderWithCache.java 57.14% 17 Missing and 1 partial ⚠️
...f/fhir/utility/npm/MeasureOrNpmResourceHolder.java 66.66% 10 Missing and 4 partials ⚠️
...qf/fhir/cr/measure/r4/R4CareGapsBundleBuilder.java 38.09% 11 Missing and 2 partials ⚠️
...s/cqf/fhir/utility/repository/ig/IgRepository.java 73.52% 7 Missing and 2 partials ⚠️
...ir/utility/npm/MeasureOrNpmResourceHolderList.java 81.08% 5 Missing and 2 partials ⚠️
... and 8 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #729      +/-   ##
============================================
- Coverage     72.56%   72.42%   -0.15%     
- Complexity      204      205       +1     
============================================
  Files           499      511      +12     
  Lines         23405    24084     +679     
  Branches       2990     3036      +46     
============================================
+ Hits          16985    17444     +459     
- Misses         4953     5136     +183     
- Partials       1467     1504      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukedegruchy lukedegruchy changed the title Ld 20250829 npm for qualifying resources round 3 Wire up NPM for measure evaluation Sep 3, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukedegruchy